Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-maintain to auto-update Dependencies and auto-fix lints #58

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Swatinem
Copy link
Collaborator

@Swatinem Swatinem commented Nov 11, 2024

See https://github.com/Swatinem/rust-maintain.

I published this action a while back, but haven’t hooked it up yet to an existing repo.

@Swatinem Swatinem self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (98cb909) to head (dd5e8bc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   98.53%   98.52%   -0.02%     
==========================================
  Files          21       21              
  Lines        6775     6775              
==========================================
- Hits         6676     6675       -1     
- Misses         99      100       +1     
Components Coverage Δ
core 98.60% <ø> (-0.02%) ⬇️
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem force-pushed the swatinem/rust-maintain branch from fa8fd27 to dd5e8bc Compare November 11, 2024 11:37
Copy link
Collaborator

@matt-codecov matt-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change our dependabot config in some way to delegate to this action?

pull-requests: write

steps:
# you should use a *pinned commit*:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder about software supply chain issues and auditing your dependencies: https://github.com/Swatinem/rust-maintain?tab=readme-ov-file#permissions--security :-)

As this action is running with hightened permissions.

@Swatinem Swatinem merged commit c7a937c into main Nov 12, 2024
14 checks passed
@Swatinem Swatinem deleted the swatinem/rust-maintain branch November 12, 2024 08:54
@Swatinem
Copy link
Collaborator Author

Well, good that I run this on a real world repo, there was two problems with this run:

  • It didn’t trigger the CI job to run. This is weird and probably a github issue. PRs should trigger CI, no matter if the push happens from within CI or from a real human.
  • Afterwards, it was complaining that the commit was not signed, as branch protection rules require that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants